⬆ Bump time-machine to 3.2.0#257
Merged
Merged
Conversation
YuriiMotov
commented
Jun 18, 2026
patrick91
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading
time-machineto version3.xrequires fixing test that mocks themonotonicusingtime_machine.shift.Since version
3.0.0,time-machinedoesn't mocktime.monotonic(see release notes). So,test_stream_build_logs_retry_timeouttests started to fail.I fixed it in 1109caa.
There are 3 more tests that are somehow related to logic that uses
monotonic:test_fetch_access_token_uses_default_timeout- already usespatchwithside_effect- no changes neededtest_short_wait_messages- mockedmonotonicincorrectlytest_long_wait_messages- mockedmonotonicincorrectlytest_short_wait_messagesandtest_long_wait_messagesdidn't fail because they didn't actually tested what they claimed (didn't test that expected "long wait" or "short wait" messages appear in output).So, I updated these 2 tests to actually test that arrays with messages are accessed (see commit 6ea3ee8), and then
test_long_wait_messagestest started to fail (as expected).I fixed the way these tests mock
monotonicas well in commits 37781be and 85c3b80